Graphman deploy command #4930
Merged
Graphman deploy command #4930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
force-pushed
the
krishna/graphman-deploy
branch
from
2fded3b
to
dc18ee1
Compare
lutter
approved these changes
Oct 23, 2023
|
|
||
| /// The url of the graph-node | ||
| #[clap(long, short, default_value = "http://localhost:8020")] | ||
| url: String, |
There was a problem hiding this comment.
It would be awesome if we would not need a url, but getting away from that might be pretty tough as we would have to instantiate our own SubgraphRegistrar; if the default is ok in most cases, I think it's not a big deal.
There was a problem hiding this comment.
That didn't cross my mind, just took a look at how that would turn out. We still would need to provide a NodeID when creating a new SubgraphRegistrar.
And the default_value for the url i believe is almost always ok unless the indexer change it explicitly. So we can go with this now and update in the future?
There was a problem hiding this comment.
Yes, let's not hold this up because of the URL; just go ahead and merge
incrypto32
force-pushed
the
krishna/graphman-deploy
branch
from
dc18ee1
to
e821600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4842