- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.1k
 
Aggregations (write side) #5082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            28 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      d1b195f
              
                graph: Remove TypeInfo.fields; use the fields of the included type
              
              
                lutter 93a39d4
              
                graph: Merge TypeInfo and TypeKind into one enum
              
              
                lutter 5911dad
              
                graph: Simplify TypeInfo
              
              
                lutter eb976a3
              
                graph, store: Make using InputSchema::object_type on an interface an …
              
              
                lutter 9f942a6
              
                graph: Add a very simple schema test for timeseries
              
              
                lutter d975f94
              
                graph: Validate timeseries and aggregation types
              
              
                lutter 31a8c8c
              
                graph: Aggregation type
              
              
                lutter 040a433
              
                store: Test store get/set disallows interfaces
              
              
                lutter 8483f8f
              
                graph, runtime: Disallow store_set/get/remove for all but @entity
              
              
                lutter 150dc63
              
                graph, store: Generate DDL for aggregations
              
              
                lutter a7bd9d5
              
                graph: Provide context when parsing an id fails
              
              
                lutter dfc8472
              
                graph: Parse @entity flags into our ObjectType
              
              
                lutter 362572c
              
                all: Remove explicit BlockPtr argument from process_mapping_trigger
              
              
                lutter ef09512
              
                all: Provide the block time to mapping handlers
              
              
                lutter d6f4813
              
                all: Pass the timestamp of the current block to the store
              
              
                lutter 4b7a332
              
                core, graph, store: Store block time in PoI
              
              
                lutter 6bd54f8
              
                graph, substreams: Suppress some doc generation to avoid name conflicts
              
              
                lutter fa3ad33
              
                graph, store: Track time when last rollup for timeseries happened
              
              
                lutter cc788a9
              
                graph, runtime: Override user-supplied timestamp in store.set
              
              
                lutter 28cc721
              
                graph, store: Perform rollups of aggregations
              
              
                lutter c28381e
              
                all: Thread the spec version into InputSchema validation
              
              
                lutter 0f6498d
              
                graph: Gate aggregations and Int8 id on new spec version
              
              
                lutter 90587d5
              
                graph, store: Add a min aggregate fn
              
              
                lutter ac6a1dd
              
                store, graph: Add first and last aggregate functions
              
              
                lutter a54af2b
              
                docs: Document aggregations
              
              
                lutter a5b98d7
              
                graph, store: Rename count to `AggregateFn::Count`
              
              
                lutter 8eaa3e5
              
                substreams: Make a missing timestamp an error
              
              
                lutter c3f4ec4
              
                graph: Fix typo
              
              
                lutter File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this type be called something like MaybeBlockTime or something just to indicate it may be none even though it's not an option?
I guess the substreams notion of blocks doesn't fit the aggregations model anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
NONEthing should really go away (maybe except for tests) I just put it there for the few cases where I wasn't sure what's happening (like substreams)