Support eth_getBalance in mapping #5202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
force-pushed
the
incrypto32/eth-get-balance
branch
from
d5b71d3
to
6fee9e2
Compare
incrypto32
force-pushed
the
incrypto32/eth-get-balance
branch
2 times, most recently
from
f1249d3
to
ad9dd45
Compare
lutter
approved these changes
Feb 14, 2024
| eth_adapter: &EthereumAdapter, | ||
| ctx: HostFnCtx<'_>, | ||
| wasm_ptr: u32, | ||
| ) -> Result<AscPtr<AscBigInt>, HostExportError> { |
There was a problem hiding this comment.
Do we need to charge gas for this call? I am not sure about the mechanics/reasoning of gas, but it feels wrong to make this free.
There was a problem hiding this comment.
Right, this shouldn't be gas free. @leoyvens how would we determine a good gas value for eth_getBalance?
There was a problem hiding this comment.
I suppose we can start with charging the same we charge for eth_call.
|
For the failing unit tests, if you rebase onto latest master, the tests should pass. |
|
Oh, one more thing: do we need a new spec or API version because this adds a host fn? |
incrypto32
force-pushed
the
incrypto32/eth-get-balance
branch
from
193a93c
to
4232b32
Compare
incrypto32
force-pushed
the
incrypto32/eth-get-balance
branch
from
4232b32
to
eb46cec
Compare
incrypto32
force-pushed
the
incrypto32/eth-get-balance
branch
from
84c073b
to
6ecc831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #895