graphman: Add simpler chain rewind command to delete blocks
#5645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rewinds all subgraphs on a chain to a specified block. It has most of the same arguments as `graphman rewind`, but takes a chain name instead of a list of deployments.
mangas
reviewed
Oct 1, 2024
| .execute(conn) | ||
| .map_err(Error::from) | ||
| } | ||
| Storage::Private(Schema { blocks, .. }) => { |
There was a problem hiding this comment.
Would be great to ensure this can work when the block cache shard is not the primary. Would also be awesome if we could have some integration tests for this functionality
There was a problem hiding this comment.
I think it does work because the ChainStore should already always have the right pool when it gets created. If you already tested that's great otherwise maybe rewind something in staging
mangas
reviewed
Oct 1, 2024
| ethereum_networks::table.filter(ethereum_networks::name.eq(&self.chain)), | ||
| ) | ||
| .set(( | ||
| ethereum_networks::head_block_number.eq(block_ptr_to.number as i64), |
There was a problem hiding this comment.
I think there is somewhere we keep the firehose cursor, I think this table has a firehose cursor too, that should be set to empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler version of #5486, which adds a command to delete blocks past a certain point:
Note that deployments are not rewound here.