Asyncify some functions in EthereumAdapter #5955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
reviewed
Apr 22, 2025
Comment on lines
1347
to
1350
| Box::pin(web3.eth().block_with_txs(BlockId::Hash(block_hash))) | ||
| .compat() | ||
| .from_err() | ||
| .compat() |
Member
There was a problem hiding this comment.
Suggested change
| Box::pin(web3.eth().block_with_txs(BlockId::Hash(block_hash))) | |
| .compat() | |
| .from_err() | |
| .compat() | |
| let web3 = web3.clone(); | |
| async move { | |
| web3.eth() | |
| .block_with_txs(BlockId::Hash(block_hash)) | |
| .await | |
| .map_err(Error::from) | |
| } |
Collaborator
Author
There was a problem hiding this comment.
Nice! I am incorporating that into the PR
incrypto32
approved these changes
Apr 22, 2025
Member
incrypto32
left a comment
incrypto32
left a comment
There was a problem hiding this comment.
LGTM! There's still some leftover futures01 usage, but we can tackle that later.
Collaborator
Author
|
Yeah, we'll have to make a few more passes over the codebase to get rid of all the futures01 |
lutter
force-pushed
the
lutter/eth-async
branch
from
fc171fc to
45dda04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.