Feat: Expose subgraph table sizes in SubgraphIndexingStatus #6201
+157
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitrovmaksim
changed the title
dimitrovmaksim
force-pushed
the
feat/add-table-sizes-to-indexing-status
branch
from
987c599 to
6c786c0
Compare
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
dimitrovmaksim
force-pushed
the
feat/add-table-sizes-to-indexing-status
branch
from
6c786c0 to
b1b19cc
Compare
incrypto32
approved these changes
Oct 23, 2025
|
|
||
| let rows = match result { | ||
| Ok(rows) => rows, | ||
| Err(e) if e.to_string().contains("has not been populated") => Vec::new(), |
There was a problem hiding this comment.
Minor nitpick: Is there no typed error for this? string matching might be fragile if diesel changes the error message.
There was a problem hiding this comment.
Feel free to ignore if there is no typed error for this
There was a problem hiding this comment.
This is a postgre error, and it is returned as Unknown
Unknown(materialized view "subgraph_sizes" has not been populated)
So I don't think there's another way
|
Let's wait for this PR #6194 to be merged before this one, so I can update to async logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5470
What this PR does:
SubgraphIndexingStatus. The data is collected from thesubgraph_sizesmaterialized view.subgraphsargument for therindexingStatusesquery required. After the changes in handle empty array in indexing status query #6143, calling the query without an argument is redundant because it will always return an empty array.