graph: emit a block only when there's a block_ptr #6215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this was merged graphprotocol#5160 substreams fatal errors can write SubgraphError{ block_ptr: None }. This introduces a bug that shows in Status API as those records can surface as fatalError.block = null violating the schema of type Block { hash: Bytes! number: BigInt! } A later commit graphprotocol#5971 makes it much easier to trigger this when doing a status API that returns all subgraphs (empty [] array for deployment ID) as failed substreams linger on in the indexing status set as paused instead of being unassigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this was merged #5160 substreams fatal errors surface and can write SubgraphError{ block_ptr: None }. This introduces a bug that shows in Status API as those records can have fatalError.block = null violating the schema of type Block { hash: Bytes! number: BigInt! }
A later commit #5971 makes it much easier to trigger this when calling status API to return all subgraphs (empty [] array for deployment ID) as failed subgraphs linger in the indexing status set as paused instead of being unassigned.