Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename trigger rav to Rav trigger #317

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: Rename trigger rav to Rav trigger #317

merged 2 commits into from
Sep 19, 2024

Conversation

carlosvdr
Copy link
Collaborator

Change hardcoded trigger value of 1000 to a metric tap_rav_request_trigger_value
fixes #313

Change hardcoded trigger value of 1000 to a metric tap_rav_request_trigger_value
@carlosvdr carlosvdr requested a review from gusinacio September 19, 2024 18:21
@carlosvdr carlosvdr self-assigned this Sep 19, 2024
@coveralls
Copy link

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 10946856344

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 68.331%

Totals Coverage Status
Change from base Build 10908076655: 0.07%
Covered Lines: 4216
Relevant Lines: 6170

💛 - Coveralls

Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit c693f0e into main Sep 19, 2024
10 checks passed
@gusinacio gusinacio deleted the trigger-rav-metric branch September 19, 2024 20:31
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics dashboard: wrong value for "trigger rav"
3 participants