Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add graph-indexed header in subgraph query response #522

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

shiyasmohd
Copy link
Contributor

Fixes #494

@coveralls
Copy link

coveralls commented Dec 1, 2024

Pull Request Test Coverage Report for Build 12150969087

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 80.223%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/service/src/routes/request_handler.rs 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
crates/watcher/src/lib.rs 4 92.71%
crates/service/src/routes/status.rs 7 0.0%
Totals Coverage Status
Change from base Build 12090402750: -0.04%
Covered Lines: 6827
Relevant Lines: 8510

💛 - Coveralls

Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I literally implemented this just now assuming no one did it yet, and it looks the same. So I'll give this an approval 👍

@shiyasmohd
Copy link
Contributor Author

@Theodus Thanks for the review. Pushed the changes

@Theodus Theodus merged commit a0d719f into main Dec 4, 2024
10 checks passed
@Theodus Theodus deleted the shiyasmohd/add-graph-indexed-header branch December 4, 2024 14:46
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return syncing status (latest block synced) in header of subgraph query responses
3 participants