Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: Fix polling-interval arg setting #1043

Merged
merged 1 commit into from
Nov 14, 2024
Merged

agent: Fix polling-interval arg setting #1043

merged 1 commit into from
Nov 14, 2024
+7 −7

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Nov 14, 2024

Changes

  • Move polling-interval args option to common-options so it is set/used in both single-network and multi-network modes. This fixes its usage in multi-network mode, previously it was being read in as undefined which leads to it being parsed as a 0 number, so the polling loop was going crazy with a 0 polling interval.

@fordN
agent: Fix polling-interval arg setting
5dd45c6 
- It was only being set properly in single-network mode because it
wasn't in common-options
@fordN fordN added bug Something isn't working indexer-agent labels Nov 14, 2024
@fordN fordN self-assigned this Nov 14, 2024
@fordN fordN merged commit 6d8975f into main Nov 14, 2024
9 checks passed
@fordN fordN deleted the ford/fix-polling-interval-arg branch November 14, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwerner dwerner dwerner approved these changes

Assignees

@fordN fordN

Labels
bug Something isn't working indexer-agent
Projects
Indexer
Status: 🚗 Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fordN @dwerner