Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L2 support for Indexer Agent #668

Merged
merged 16 commits into from
Aug 11, 2023
Merged

L2 support for Indexer Agent #668

merged 16 commits into from
Aug 11, 2023

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Jun 13, 2023 •
edited
Loading

Adds the capacity for the Agent to interact with multiple protocol networks (Blockchains that host The Graph Protocol) by running a single instance of the indexer-agent program.

TODO:

Fixes #675

@tilacog tilacog force-pushed the tiago/multi-network-aware-components branch from 0e9d96b to f9a47ab Compare June 13, 2023 17:27
@tilacog
Copy link
Contributor Author

tilacog commented Jun 13, 2023

Force pushed to rebase on top of latest main

@tilacog tilacog force-pushed the tiago/multi-network-aware-components branch from b6c23d0 to 1232c60 Compare June 20, 2023 13:50
@tilacog
Copy link
Contributor Author

tilacog commented Jun 20, 2023

Rebased on top of latest main

@tilacog tilacog force-pushed the tiago/multi-network-aware-components branch from d33aa0a to a1ac1ab Compare June 20, 2023 16:22
@tilacog tilacog requested review from fordN and hopeyen and removed request for fordN June 22, 2023 14:51
hopeyen
hopeyen reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are looking very impressive, only functional people can make some of these updates! I skimmed through briefly and left some minor questions. will take a more careful look on a later date 💯 💯 💯

packages/indexer-cli/src/commands/indexer/rules/get.ts Show resolved Hide resolved
packages/indexer-agent/src/commands/common-options.ts Show resolved Hide resolved
packages/indexer-agent/src/agent.ts Outdated Show resolved Hide resolved
packages/indexer-agent/src/commands/start.ts Outdated Show resolved Hide resolved
packages/indexer-agent/src/agent.ts Outdated Show resolved Hide resolved
packages/indexer-common/src/multi-networks.ts Show resolved Hide resolved
packages/indexer-agent/src/db/migrations/11-add-protocol-network-field.ts Show resolved Hide resolved
packages/indexer-common/src/indexer-management/models/indexing-rule.ts Show resolved Hide resolved
packages/indexer-common/src/operator.ts Show resolved Hide resolved
packages/indexer-service/src/commands/start.ts Show resolved Hide resolved
@tilacog tilacog force-pushed the tiago/multi-network-aware-components branch from cd45e26 to 6320934 Compare June 28, 2023 16:24
@tilacog
Copy link
Contributor Author

tilacog commented Jun 28, 2023

Force pushed to rebase on top of latest main

@tilacog tilacog force-pushed the tiago/multi-network-aware-components branch 2 times, most recently from 0b087a8 to 51e2074 Compare July 24, 2023 18:21
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 27, 2023
View reviewed changes
packages/indexer-agent/src/syncing-server.ts
} catch (e) {
return res
.status(404)
.send(`Unknown network identifier: '${unvalidatedNetworkIdentifier}'`)

Check failure

Code scanning / CodeQL

Reflected cross-site scripting High

Cross-site scripting vulnerability due to a
user-provided value
Loading
.
@tilacog tilacog force-pushed the tiago/multi-network-aware-components branch 3 times, most recently from 41ecb29 to 109a661 Compare July 31, 2023 19:02
@tilacog tilacog mentioned this pull request Aug 2, 2023
Open
@tilacog tilacog force-pushed the tiago/multi-network-aware-components branch from ce29a5c to 8b5feb0 Compare August 3, 2023 17:49
@tilacog tilacog force-pushed the tiago/multi-network-aware-components branch from 9fada28 to 083f454 Compare August 7, 2023 18:14
@tilacog
Copy link
Contributor Author

tilacog commented Aug 7, 2023

Force pushed to squash commits

@tilacog tilacog mentioned this pull request Aug 7, 2023
Closed
@tilacog tilacog force-pushed the tiago/multi-network-aware-components branch from 5198f97 to b24b820 Compare August 10, 2023 16:06
fordN
fordN requested changes Aug 10, 2023
View reviewed changes
packages/indexer-agent/src/__tests__/indexer.ts Show resolved Hide resolved
packages/indexer-agent/src/__tests__/indexer.ts Show resolved Hide resolved
packages/indexer-agent/src/agent.ts Outdated Show resolved Hide resolved
packages/indexer-agent/src/agent.ts Outdated Show resolved Hide resolved
packages/indexer-agent/src/agent.ts Outdated Show resolved Hide resolved
packages/indexer-agent/src/db/migrations/11-add-protocol-network-field.ts Outdated Show resolved Hide resolved
packages/indexer-cli/src/command-helpers.ts Show resolved Hide resolved
packages/indexer-cli/src/command-helpers.ts Show resolved Hide resolved
packages/indexer-cli/src/commands/indexer/rules/get.ts Show resolved Hide resolved
packages/indexer-service/src/commands/start.ts Outdated Show resolved Hide resolved
@fordN
Copy link
Contributor

fordN commented Aug 10, 2023

Have we been able to observe successful collecting of fees in multi network mode?

This was referenced Aug 11, 2023
Closed
Closed
Open
@tilacog tilacog force-pushed the tiago/multi-network-aware-components branch from d9f2d7c to 1fde626 Compare August 11, 2023 17:43
fordN
fordN approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 🚀

@fordN fordN assigned fordN and tilacog and unassigned fordN Aug 11, 2023
@fordN fordN added the enhancement New feature or request label Aug 11, 2023
@fordN fordN added this to the Multiple Chain Operation milestone Aug 11, 2023
@tilacog tilacog merged commit e839983 into main Aug 11, 2023
8 checks passed
@tilacog tilacog deleted the tiago/multi-network-aware-components branch August 11, 2023 18:21
This was referenced Aug 25, 2023
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopeyen hopeyen hopeyen left review comments

@fordN fordN fordN approved these changes

Assignees

@tilacog tilacog

Labels
enhancement New feature or request
Projects
Indexer
Status: 🚗 Merged
Milestone
Multiple Chain Operation
Development

Successfully merging this pull request may close these issues.

Failed to collect receipts in exchange for query fee voucher: invalid BigNumber value
3 participants
@tilacog @fordN @hopeyen