adds event origin to the transform proto #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lavabyrd Can you update your local protoc to v3.20.1 version before generating file to make the github workflow pass |
yup i'm trying to at the moment. The problem is the latest build on brew (mac package installer) is 3.19.4, trying to figure out how to build the latest version manually instead - https://formulae.brew.sh/formula/protobuf#default looks like there's a PR open for it but it hasn't been merged yet - Homebrew/homebrew-core#99843 |
Seb-figment
approved these changes
May 18, 2022
pienkowb
reviewed
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://figmentio.atlassian.net/browse/GRAPH-358