You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Parser.Parse takes around 18s to parse the 58K file from the attached archive. You can run the following code to reproduce it (the path variable should contain the path to the extracted file):
Oh, I get it. The whole point is that the file is binary and its parsing error occurs. Time is wasted on getting an error message in this method, which makes numerous extremely inefficient string replacement calls.
sungam3r
added a commit
to sungam3r/parser
that referenced
this issue
Mar 8, 2019
My explanation was incorrect. The point is not even in allocations, but in the fact that the iterator for each character in the source line called Replace method, which in turn again ran over the entire line. In any case, now there are no such problems.
Parser.Parse takes around 18s to parse the 58K file from the attached archive. You can run the following code to reproduce it (the path variable should contain the path to the extracted file):
Found via SharpFuzz.
The text was updated successfully, but these errors were encountered: