Update CI scripts #104
Update CI scripts #104
Conversation
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="GraphQL.SystemTextJson" Version="4.0.2" /> | ||
| <PackageReference Include="GraphQL.SystemTextJson" Version="$(GraphQLTestVersion)" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.8.0" /> | ||
| <PackageReference Include="Shouldly" Version="2.8.3" /> |
There was a problem hiding this comment.
Huh? 4.0.3 doesn't exist
There was a problem hiding this comment.
There was a problem hiding this comment.
I only referenced 4.0.2 because we had some critical bugfixes in 4.0.2 and really 4.0.0 and 4.0.1 should not ever be used. However, this library should work fine with all 4.x versions.
There was a problem hiding this comment.
OK. I'm talking about Shouldly version.
|
I'm going to test and see if it's pulling in the specified version of GraphQL ..... |
| paths: | ||
| - src/** | ||
| - .github/workflows/** | ||
| - "*.sln" |
There was a problem hiding this comment.
🤔 Sln file is not in the src folder. In other repositories, it is inside the src folder. What option do we choose?
There was a problem hiding this comment.
I thought about it and decided it was more appropriate here because it references files in this folder and the .github folder and so on. If not, then it should be in the src folder.
There was a problem hiding this comment.
The sln file should not have to traverse up a directory - e.g. ../.github/workflows/testcode.yml
There was a problem hiding this comment.
I think that the sln file used to only reference the projects, at which point it was most appropriately in the src folder. But then you/we started adding references to the documentation and other files. So now it really should be moved in the other repos.
It is confirmed to be working properly. |
Fixes #95