Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile expression ahead of time #183

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Compile expression ahead of time #183

merged 1 commit into from
Oct 11, 2022

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Oct 11, 2022

Fixes #182

@nbarbettini
Copy link

Nice!

@codecov-commenter
Copy link

Codecov Report

Merging #183 (f6dfae9) into master (9cf539c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   71.26%   71.33%   +0.06%     
==========================================
  Files          16       16              
  Lines         449      450       +1     
  Branches       43       43              
==========================================
+ Hits          320      321       +1     
  Misses        123      123              
  Partials        6        6              
Impacted Files Coverage Δ
src/GraphQL.Relay/Types/NodeGraphType.cs 66.66% <100.00%> (+0.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Shane32 Shane32 merged commit aef07b8 into master Oct 11, 2022
@Shane32 Shane32 deleted the Shane32-patch-1 branch October 11, 2022 12:35
@sungam3r sungam3r added the performance Issue or pull request about performance problems label Nov 3, 2022
@sungam3r
Copy link
Member

sungam3r commented Nov 3, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Issue or pull request about performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Id() helper is slow
4 participants