Issue 47 #88
Merged
Issue 47 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aphql.Relay.StarWars to .net5.0 and graphql-dotnet 4.0.2.
Co-authored-by: Shane Krueger <shane@acdmail.com>
…tead of by object
Co-authored-by: Shane Krueger <shane@acdmail.com>
Fix merge conflict
Shane32
reviewed
Apr 16, 2021
sungam3r
added
enhancement
This was referenced Apr 26, 2021
Open
|
@Shane32 Got some time to get back to this. I made the context come first as we were discussing in the conversation above. I think it makes more sense as the context seems to come first in many other places. |
|
@JoeHartzell thanks! if you can merge in the latest changes from master it would be helpful. Thanks!! |
Shane32
approved these changes
Apr 30, 2021
sungam3r
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #47.
I added the context as a parameter to the NodeGraphType.GetById method. I also had to fix all the example projects as this is a breaking change.