Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file upload/download documentation to readme #909

Merged
merged 2 commits into from
Aug 20, 2022
Merged

Add file upload/download documentation to readme #909

merged 2 commits into from
Aug 20, 2022

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Aug 19, 2022 •
edited
Loading

See: #307

@Shane32 Shane32 self-assigned this Aug 19, 2022
@Shane32
Copy link
Member Author

Shane32 commented Aug 19, 2022 •
edited
Loading

I might suggest expanding this into a sample program (including tests) in the future. We may also want to consider including multipart file decoding as a built-in feature. And finally, we may want to consider adding a built-in graph type for base64 encoded strings, perhaps with automatic mapping to byte arrays.

sungam3r
sungam3r reviewed Aug 20, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
sungam3r
sungam3r reviewed Aug 20, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
sungam3r
sungam3r reviewed Aug 20, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
sungam3r
sungam3r reviewed Aug 20, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Shane32 @sungam3r
Apply suggestions from code review
0c00652 
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@Shane32 Shane32 merged commit a2eb219 into master Aug 20, 2022
@Shane32 Shane32 deleted the file_upload_comments branch August 20, 2022 05:00
Kent-Chen-Conning added a commit to Conning/graphql-dotnet-server that referenced this pull request Oct 28, 2022
@Kent-Chen-Conning
Merge commit 'af5ac03f9f5505d476850cee23c5aaa145110c94' into TRAC-669…
977b74c 
…4-upgrade-to-7.1

* commit 'af5ac03f9f5505d476850cee23c5aaa145110c94': (352 commits)
  Update response content type for `ExecutionResultActionResult` (graphql-dotnet#923)
  Bump Serilog.Sinks.Console from 4.0.1 to 4.1.0 (graphql-dotnet#924)
  Select return content type based on Accept header (graphql-dotnet#919)
  Allow the configuration of the response content type via options (graphql-dotnet#913)
  Change default response content type to match draft spec (graphql-dotnet#918)
  Add note regarding ASP.NET Core 2.1 support policy (graphql-dotnet#914)
  Bump Microsoft.NET.Test.Sdk from 17.3.0 to 17.3.1 (graphql-dotnet#920)
  Bump Shouldly from 4.0.3 to 4.1.0 (graphql-dotnet#912)
  Bump GraphQL to 7.0.2 (graphql-dotnet#911)
  Add file upload/download documentation to readme (graphql-dotnet#909)
  Fix packing readme and analysis recommendations (graphql-dotnet#897)
  Fix call to UseApolloTracing in Complex sample (graphql-dotnet#903)
  Add docs link
  Update migration document link (graphql-dotnet#895)
  Add federation tracing extension method (graphql-dotnet#894)
  Bump to GraphQL.NET 7.0.0 (graphql-dotnet#893)
  Feature/assembly-strongname (graphql-dotnet#892)
  Add JWT bearer authentication sample (graphql-dotnet#885)
  Bump Microsoft.AspNetCore.TestHost from 6.0.0 to 6.0.8 (graphql-dotnet#889)
  Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.3.0 (graphql-dotnet#890)
  ...

# Conflicts:
#	src/Transports.AspNetCore/GraphQLExtensions.cs
#	src/Transports.AspNetCore/GraphQLHttpMiddleware.cs
#	src/Transports.AspNetCore/Transports.AspNetCore.csproj
#	src/Transports.Subscriptions.Abstractions/ProtocolMessageListener.cs
#	src/Transports.Subscriptions.Abstractions/Subscription.cs
#	src/Transports.Subscriptions.Abstractions/SubscriptionServer.cs
#	src/Transports.Subscriptions.Abstractions/Transports.Subscriptions.Abstractions.csproj
#	src/Transports.Subscriptions.WebSockets/GraphQlWebSocketsMiddleware.cs
#	src/Transports.Subscriptions.WebSockets/Transports.Subscriptions.WebSockets.csproj
#	src/Transports.Subscriptions.WebSockets/WebSocketConnection.cs
#	src/Transports.Subscriptions.WebSockets/WebSocketReaderPipeline.cs
#	src/Ui.GraphiQL/Ui.GraphiQL.csproj
#	src/Ui.Playground/Ui.Playground.csproj
#	src/Ui.Voyager/Ui.Voyager.csproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungam3r sungam3r sungam3r approved these changes

Assignees

@Shane32 Shane32

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shane32 @sungam3r