run CI for #7369 #7393
run CI for #7369 #7393
Conversation
While the schema check is ignoring missing git information: https://github.com/graphql-hive/console/blob/main/packages/libraries/cli/src/commands/schema/check.ts#L232 Schema publish does not. Thus our pipelines fail due to missing git and stating author/commit cannot be found. https://github.com/graphql-hive/console/blob/main/packages/libraries/cli/src/commands/schema/publish.ts#L234
Summary of ChangesHello @n1ru4l, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
n1ru4l
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR updates the cli.dockerfile to install git and applies some Docker image size optimizations. My feedback includes a suggestion to further reduce the image size by cleaning the apt package cache, aligning with the repository's style guide focus on performance.
| FROM node:22.13.0-slim | ||
|
|
||
| RUN apt-get update && apt-get install -y ca-certificates | ||
| RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates git && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
To further reduce the image size in line with the style guide's focus on performance, add apt-get clean to this command. This will remove downloaded package archives (.deb files).
RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates git && apt-get clean && rm -rf /var/lib/apt/lists/*
References
- The repository style guide (line 5) emphasizes a focus on performance. Reducing Docker image size is a performance optimization, as it leads to faster image pulls and less disk space usage. (link)
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7393.hive-storybook.pages.dev |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7393.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
2 participants
run CI for #7369