Skip to content

Avoid explicitly inject ObjectMapper to the ObjectMapper #177

Closed
@sammyhk

Description

@sammyhk

ConfiguringObjectMapperProvider explicitly inject ObjectMapper to the ObjectMapper:
https://github.com/graphql-java-kickstart/graphql-java-servlet/blob/master/src/main/java/graphql/servlet/ConfiguringObjectMapperProvider.java#L27
Which is used in VariablesDeserializer:
https://github.com/graphql-java-kickstart/graphql-java-servlet/blob/master/src/main/java/graphql/servlet/internal/VariablesDeserializer.java#L18

Checked Jackson 2 API, this is not needed by using ObjectCodec API (abstract class of ObjectMapper) which can achieve the same goal.
Example (Before):

objectMapper.readValue(str, typeReference);

(After):

objectCodec.readValue(objectCodec.getFactory().createParser(str), typeReference);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions