Added support for query batching #48
Conversation
|
Thanks for adding a PR for this! I'll take a look at it as soon as I can. |
|
|
||
| private void doBatchedQuery(Iterator<GraphQLRequest> graphQLRequests, GraphQLSchema schema, GraphQLContext context, Object rootObject, HttpServletRequest req, HttpServletResponse resp) throws Exception { | ||
| resp.setContentType(APPLICATION_JSON_UTF8); | ||
| resp.setStatus(STATUS_OK); |
There was a problem hiding this comment.
A call to query below might result in an exception. Is it ok to set this here?
|
@apottere Have you had a chance to look at this yet? We're actually pining to have this in production here at Bloomberg BNA for one of our projects. We refactored one of our sites to use Apollo not realizing until it was too late that Apollo required server support for query batching. |
|
@ronald-d-rogers sorry, I've been swamped lately and just got a chance to review it. It looks good to me, thanks for the great work on this 👍 |
|
Thanks! Don't suppose we could get a release? We were just about to make the decision to bundle the forked version into the build but now that this has been merged... |
|
I take that back, looks like a release has already been cut! |
|
@ronald-d-rogers #295 Have you tried some kind of this approach? |
No description provided.