Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification updates #5

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Specification updates #5

merged 2 commits into from
Oct 11, 2016

Conversation

sergehuber
Copy link
Contributor

This pull request contains the following modifications and fixes :

- Update graphql-java-annotations to 0.11.0
- Fix minor typo in project description
…, as is now document in the latest specification here : http://graphql.org/learn/serving-over-http/#post-request

This change is also now done on GraphiQL : graphql/graphiql#168
- Add support for GET parameters (query and variables) as is also specified here : http://graphql.org/learn/serving-over-http/#get-request
- Fix some NPEs when no parameters where specified.
@sergehuber sergehuber changed the title Spec updates Specification updates Oct 11, 2016
@yrashk yrashk merged commit 0f0052a into graphql-java-kickstart:master Oct 11, 2016
@yrashk
Copy link
Contributor

yrashk commented Oct 11, 2016

Thank you! ❤️

sergehuber added a commit to Jahia/graphql-core that referenced this pull request Oct 11, 2016
…updates libraries and minor bug corrections. See graphql-java-kickstart/graphql-java-servlet#5

- Add some description to types
- Temporarily deactivate node type registration as we are still having some issues with it.
- Some POM cleanups.
@sergehuber
Copy link
Contributor Author

You're welcome ! Are you planning to perform a release with these changes or are there more planned before that happens ?

@yrashk
Copy link
Contributor

yrashk commented Oct 12, 2016

Unless you have anything else pending in the short term, I will release it immediately.

@sergehuber
Copy link
Contributor Author

Actually I do, I just saw that the operationName support was not fully implemented. I will implement it in another pull request.

@sergehuber sergehuber deleted the spec-updates branch October 12, 2016 09:34
@yrashk
Copy link
Contributor

yrashk commented Oct 12, 2016

Great! Will wait for that PR and release a new version after that.

On Wed, Oct 12, 2016 at 4:34 PM Serge Huber notifications@github.com
wrote:

Actually I do, I just saw that the operationName support was not fully
implemented. I will implement it in another pull request.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#5 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAABxL12OGUfD_9dW1F676Q95NvlsrXrks5qzKmtgaJpZM4KTxL6
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants