Add new GraphQLDirectiveProvider for custom directives #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive defs in schema
federicorispo
requested changes
Feb 7, 2024
graphql-java-servlet/src/main/java/graphql/kickstart/servlet/osgi/GraphQLDirectiveProvider.java
Outdated
Show resolved
Hide resolved
graphql-java-servlet/src/main/java/graphql/kickstart/servlet/osgi/GraphQLDirectiveProvider.java
Outdated
Show resolved
Hide resolved
|
Except from the two suggestions added, everything else looks good to me |
Co-authored-by: Federico Rispo <dev@federicorispo.com>
federicorispo
approved these changes
Feb 8, 2024
|
@gflores-jahia Could you align/reopen this PR pointing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#555
Currently graphql schema with custom directives can fail validation due to missing custom directive definitions when trying to build the schema.
Add new GraphQLDirectiveProvider to be able to insert these custom directive definitions and build/validate schema without issues.