Skip to content

Add support for java.time.Instant in DateTimeScalar scalar #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steinmaerivoet opened this issue Jun 4, 2021 · 3 comments
Closed

Comments

@steinmaerivoet
Copy link

No description provided.

@BlasiusSecundus
Copy link

There is actually an open PR with that feature: #26

@wallind
Copy link

wallind commented Feb 17, 2023

There is actually an open PR with that feature: #26

seems the development team has closed that PR and made a statement solidifying intent NOT TO INCLUDE Instant support #26 (comment)

Thanks for opening a PR, and sorry it has taken so long to reply.

Similarly to #52, I discussed with the team and we decided to not include Instant, Date and LocalDateTime.

For Instant and LocalDateTime, the challenge is neither has an offset as @andrewsf said. It would be better for the user to choose the offset rather than the library to assume an offset.

For Date, we'd rather not support this outdated Java class.

@dondonz
Copy link
Member

dondonz commented Jan 2, 2024

Hey everyone, thanks for contributing to this thread. As Instant doesn't include an offset we'd prefer not to include this scalar in the library.

@dondonz dondonz closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants