Add support for Instant and Date in DateTime scalar #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this improvement be merged? |
|
There is not much this library misses but the support for few missing types. Can we merge this extremely small and straightforward PR which addresses concerns from #26 @andrewsf @Neoklosch @caio-picpay? 🙏 |
|
Hello, thanks for opening a pull request, and apologies for taking so long to reply. I discussed with the team and we decided to not include For For |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Instant and Date types in the DateTime scalar.
Similar to #26 but with the proposed fixes.