Use applied directives rather than directives by themselves #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquedacostacambio
approved these changes
Sep 8, 2022
|
@enriquedacostacambio any chance we can get this merged if it's okay? This is stopping us from updating to the latest GraphQL tools. Thanks in advance! |
bbakerman
reviewed
Sep 15, 2022
| import jakarta.validation.Payload; | ||
| import java.lang.annotation.Retention; | ||
| import java.lang.annotation.Target; | ||
| import java.util.*; |
There was a problem hiding this comment.
This annoys me - please turn on expand all imports
bbakerman
requested changes
Sep 15, 2022
|
Ok progress over perfection - I will let this in and we can fix up the |
Yeah no problem, I'll do that today. Sorry about that, it's the default setting of Intellij and I didn't see it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use the new
AppliedDirectivesinstead of the oldDirective.This seems to break when upgrading to graphql-java 19, and it does still work for graphql-java 18.