Skip to content

Automatic Module Name clashes with graphql-java Module #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brianoliver opened this issue Feb 15, 2022 · 2 comments · Fixed by #118
Closed

Automatic Module Name clashes with graphql-java Module #110

brianoliver opened this issue Feb 15, 2022 · 2 comments · Fixed by #118

Comments

@brianoliver
Copy link

brianoliver commented Feb 15, 2022

In a modular java system it's not possible to use the graphql-java module and the java-loader as that have the same automatic module name 'com.graphqljava'

Automatic-Module-Name: com.graphqljava

I think the automatic module name for the java-dataloader module should be:

Automatic-Module-Name: org.dataloader

To match the package names.

@hanson76
Copy link

hanson76 commented May 2, 2022

And comments on this?
This is bit of a problem, we can't upgrade GraphQL-Java past version 17 as it is now.

@bbakerman
Copy link
Member

By all means - can someone please make a PR and change it to org.dataloader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants