Changed Automatic Module Name to org.dataloader #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
graphql-java has the Automatic Module Name
com.graphqljava
, and it also directly depends on java-dataloader. Since java-dataloader also has the Automatic Module Namecom.graphqljava
, the module system cannot determine which module to use and so any usage of graphql-java with the module path is instantly broken.This patch changes the Automatic Module Name to
org.dataloader
since that's the root package name.Given that:
then I believe this is a passive change - not sure what the release process is around bumping versions since this is my first time contributing to this project. Let me know if I need to do anything else!