Skip to content

Changed Automatic Module Name to org.dataloader #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zrbrown
Copy link

@zrbrown zrbrown commented May 27, 2022

Fixes #110

graphql-java has the Automatic Module Name com.graphqljava, and it also directly depends on java-dataloader. Since java-dataloader also has the Automatic Module Name com.graphqljava, the module system cannot determine which module to use and so any usage of graphql-java with the module path is instantly broken.

This patch changes the Automatic Module Name to org.dataloader since that's the root package name.

Given that:

  • Automatic Module Name is only relevant when using the module path
  • java-dataloader is inherently always used with graphql-java, and so in its current state on the module path is completely broken

then I believe this is a passive change - not sure what the release process is around bumping versions since this is my first time contributing to this project. Let me know if I need to do anything else!

@bbakerman bbakerman merged commit d42e37e into graphql-java:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic Module Name clashes with graphql-java Module
2 participants