-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker image #126
base: main
Are you sure you want to change the base?
Add docker image #126
Conversation
@IvanGoncharov can you create Otherwise, if you want, you can grant me access to https://github.com/APIs-guru/graphql-voyager project and I can maintain Graphql-voyager Docker Image for you ? |
@@ -49,8 +49,7 @@ export default function renderVoyagerPage(options: MiddlewareOptions) { | |||
'Accept': 'application/json', | |||
'Content-Type': 'application/json', | |||
}, ${headersJS}), | |||
body: JSON.stringify({query: introspectionQuery }), | |||
credentials: 'include', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the problem with credentials
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -50,8 +50,7 @@ | |||
'Accept': 'application/json', | |||
'Content-Type': 'application/json', | |||
}, | |||
body: JSON.stringify({query: introspectionQuery}), | |||
credentials: 'include', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question, why do you delete it?
docker-image/Dockerfile
Outdated
|
||
ENV PORT=3001 | ||
|
||
CMD node index.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing newline at the end of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually like to have Dockerfile similar to what graphql-faker
has:
https://github.com/APIs-guru/graphql-faker/blob/master/Dockerfile
Is it possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially since it doesn't require a separate folder and package.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing newline at the end of the file.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially since it doesn't require a separate folder and package.json.
I need a place to store index.html
and this package.json
:
{
"scripts": {
"start": "node index.js"
},
"dependencies": {
"express": "^4.16.3",
"graphql-voyager": "../"
}
}
I don't want put the mess in root folder.
@IvanGoncharov What do you think of that?
@harobed We already have account here: |
Ok, I have updated Docker image name 👍 |
Note: when all will be ok, I will squash MR commits. |
@IvanGoncharov how can I help you? |
@harobed Sorry pretty busy month. |
hey guys, was there a resolve for #127 ? Trying to understand why |
@IvanGoncharov Up ? This would be awesome to use it in a docker directly |
c21e67b
to
a180bcb
Compare
a180bcb
to
ab1efcf
Compare
d5ca43d
to
6c13589
Compare
|
||
WORKDIR /graphql-voyager/ | ||
|
||
WORKDIR /graphql-voyager/docker-image/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line makes the previous one unnecessary
Great, hope to see this PR pushed. |
No description provided.