cache SVG render by md5 hash of TypeGraph #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added a commit
that referenced
this pull request
Aug 8, 2023
Fixes #197 and working on super big graphs
IvanGoncharov
added a commit
that referenced
this pull request
Aug 8, 2023
Fixes #197 and working on super big graphs
IvanGoncharov
added a commit
that referenced
this pull request
Aug 8, 2023
Fixes #197 and working on super big graphs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading very large schemas the
SVGRender.renderSvgmethod takes a very long time to calculate the svg. In larger projects the schemas don't change that often, so caching the svg string is a good way to avoid having to recalculate the svg on every page load.I used a md5 hash of TypeGraph to identify schemas and use the hash as the key for caching using localStorage.
This could probably be improved with eviction strategies or other fancier mechanisms but first I wanted to make sure there was interest in the feature.