Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JS middleware page #357

Merged
merged 1 commit into from
Sep 9, 2023
Merged

fix: JS middleware page #357

merged 1 commit into from
Sep 9, 2023

Conversation

Fllorent0D
Copy link
Contributor

Middleware jshas not been updated after major update (2.0.0).

Fixes #356

@dbartalos
Copy link

Tested change locally and resolved the issue. Nice! 👍

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Aug 30, 2023
@LunaticMuch
Copy link
Collaborator

I need to test it too

@LunaticMuch LunaticMuch self-requested a review September 4, 2023 15:23
LunaticMuch
LunaticMuch approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@LunaticMuch LunaticMuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LunaticMuch
Copy link
Collaborator

Side note: window.addEventListener is definitely an option, but maybe it would be better to align to the same code in the HTML example

@LunaticMuch LunaticMuch mentioned this pull request Sep 4, 2023
Merged
@IvanGoncharov IvanGoncharov merged commit b534f73 into graphql-kit:main Sep 9, 2023
9 checks passed
@traverse1984 traverse1984 mentioned this pull request Sep 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunaticMuch LunaticMuch LunaticMuch approved these changes

Assignees
No one assigned
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Middleware HTML broken in version 2.0.0
4 participants
@Fllorent0D @dbartalos @LunaticMuch @IvanGoncharov