tests(e2e): server with client queries #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 31.88% 31.88%
=======================================
Files 24 24
Lines 367 367
Branches 70 70
=======================================
Hits 117 117
Misses 243 243
Partials 7 7 |
|
@jasonkuhrt In 4bfcc76 you left an exposed Heroku DB string with user and password inline. You might want to regenerate the DB and store those in environment variables. Otherwise people can maliciously cause tests to fail. |
@bweis that's true but not a concern right now. Will fix when it becomes an issue. |
|
Going to merge as it is only failing in Windows now. |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28