feat: add support for BigInt scalar #56

iddan · 2021-05-22T22:56:46Z

closes #59

TODO

docs
tests

codecov-commenter · 2021-05-22T23:35:21Z

Codecov Report

Merging #56 (b125613) into main (d30ac3c) will increase coverage by 0.87%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   44.39%   45.26%   +0.87%     
==========================================
  Files          27       28       +1     
  Lines         428      433       +5     
  Branches       85       85              
==========================================
+ Hits          190      196       +6     
+ Misses        218      217       -1     
  Partials       20       20

tests/e2e/__snapshots__/e2e.test.ts.snap

src/entrypoints/scalars.ts

src/generator/models/declaration.ts

README.md

src/scalars/BigInt.ts

jasonkuhrt · 2021-05-25T22:10:05Z

Two things I want to see also happen in our support for this:

Mention which Node version is needed to support this.
watch out for this:

In order to support BigInt in JSON.parse and JSON.stringify, it is recommended to install this npm package together with this scalar. Otherwise, JavaScript will serialize the value as string. json-bigint-patch

To test that we're doing this right I would like us to add an integration test for BigInt and prove that the typeof check for a client response against a BigInt field returns BigInt and not String.

jasonkuhrt · 2021-06-01T15:15:21Z

@iddan Heya, any update?

iddan · 2021-06-02T09:53:29Z

I have not got around to looking into it yet.

iddan · 2021-06-03T15:01:21Z

Updated docs regarding JSON patch and node version.

jasonkuhrt · 2021-06-21T22:22:24Z

Please rebase, tests are fixed.

jasonkuhrt · 2021-06-22T18:47:27Z

Do you know how to update snapshots?

-- edit

I see you did here #75 so yes I guess :)

jasonkuhrt · 2021-06-22T19:28:08Z

@iddan I merged your other PR, so looks like some more conflicts for you to resolve. And the test snapshot update. Then we should be good to get this merged finally. Thanks!

README.md

tests/e2e/e2e.test.ts

jasonkuhrt · 2021-06-23T00:56:45Z

Looks like a few more snapshot updates are needed.

…ature/bigint

jasonkuhrt

LGTM!

fix: remove lingering console.log chore(docs): syntax of example in readme (graphql-nexus#89) chore(docs): mention more about updating snapshots chore(docs): syntax of example in readme (graphql-nexus#91) docs: add jsdoc for $settings (graphql-nexus#90) Co-authored-by: Jason Kuhrt <jasonkuhrt@me.com> docs: list enum members in jsdoc (graphql-nexus#92) chore: update roadmap docs: update to nexus@^1.1 api (graphql-nexus#95) chore(docs): tweak scalar writing feat: add support for BigInt scalar (graphql-nexus#56) Co-authored-by: Jason Kuhrt <jasonkuhrt@me.com> Add docs webite Update theme.config.js Fix theme.config eslint Add missing typescript dep Limit docs workflow to run only when changing docs directory Fix formatting

chore: update roadmap docs: update to nexus@^1.1 api (graphql-nexus#95) chore(docs): tweak scalar writing feat: add support for Decimal scalar Update readme Fix syntax of example in readme feat: add support for BigInt scalar (graphql-nexus#56) Co-authored-by: Jason Kuhrt <jasonkuhrt@me.com> Update src/entrypoints/scalars.ts Issue comments Update src/scalars/Decimal.ts Co-authored-by: Jason Kuhrt <jasonkuhrt@me.com> Do not use Decimal in seed in e2e

@id

## 1.0.0 (2023-01-07) ### ⚠ BREAKING CHANGES * **deps:** update dependency graphql to v16 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Rostislav Simonik <rostislav.simonik@technologystudio.sk> * scalars module only exports named exports (#187) * support latest Prisma (#164) * no types namespace (#130) * remove support for prisma 2.17 * support prisma 2.30 (#114) * Prisma Int @id maps to GraphQL Int (#23) * better names, auto-import friendly, jsdoc (#12) * validate that peer dep requirements are met * **deps:** nexua and @prisma/client are peer dependencies * hello world ### Features * add bytes scalar support ([#75](#75)) ([88fd092](88fd092)) * add default resolver for relation fields ([#25](#25)) ([4f5cd70](4f5cd70)) * add nexus_prisma bin for =<2.17 prisma users ([469c9e9](469c9e9)) * add nexusPrisma default and named export ([704f07c](704f07c)) * add peer dep support for prisma 2.18.x ([2e898ab](2e898ab)) * add support for BigInt scalar ([#56](#56)) ([67ce824](67ce824)) * add support for Decimal scalar ([#96](#96)) ([74da7c2](74da7c2)) * add support for reading configuration at generation time ([#27](#27)) ([275e03f](275e03f)) * control rejectOnNotFound client setting ([#135](#135)) ([01daf38](01daf38)) * **deps:** nexua and @prisma/client are peer dependencies ([b28217b](b28217b)) * emit model scalar fields ([#5](#5)) ([3a0a75a](3a0a75a)) * esm support ([#127](#127)) ([eec4932](eec4932)) * gentime setting for output directory ([#166](#166)) ([83889bf](83889bf)) * hello world ([9667cd0](9667cd0)) * Json & DateTime custom scalar support ([#9](#9)) ([df51143](df51143)), closes [#8](#8) * Prisma Int [@id](https://github.com/id) maps to GraphQL Int ([#23](#23)) ([624c745](624c745)) * settings system for runtime & gentime ([#42](#42)) ([ef76e45](ef76e45)) * **settings:** allow customization of prisma client import ([#49](#49)) ([c8b5f6c](c8b5f6c)) * **settings:** allow disable jsdoc guide ([#136](#136)) ([9418649](9418649)) * support latest Prisma ([#164](#164)) ([594699d](594699d)) * support prisma 2.30 ([#114](#114)) ([b7c7927](b7c7927)) * support prisma up to 2.24 ([#70](#70)) ([2704ff2](2704ff2)) * support prisma up to 3 ([#147](#147)) ([0020742](0020742)) * support projecting enums ([#18](#18)) ([1c1cd13](1c1cd13)) * turn prisma client on graphql context validation into a formal check ([#180](#180)) ([72817f1](72817f1)) * Update official Prisma support up to 2.27 ([#100](#100)) ([db1010d](db1010d)) * Use JSONResolver for Json scalar ([#231](#231)) ([e4143ac](e4143ac)) * validate that peer dep requirements are met ([7976bf5](7976bf5)) ### improve * better names, auto-import friendly, jsdoc ([#12](#12)) ([6e395b9](6e395b9)) * no types namespace ([#130](#130)) ([cbe3df8](cbe3df8)) * remove support for prisma 2.17 ([e007721](e007721)) ### Refactoring * peer dep failure state labels ([03d3c64](03d3c64)) * resolver "constraints" ([#165](#165)) ([3c9991b](3c9991b)) * **tests:** use kont for tests ([#149](#149)) ([1218c7e](1218c7e)) ### Documentation * "which should I use" guide ([599b76d](599b76d)) * add jsdoc for $settings ([#90](#90)) ([98a2267](98a2267)) * add missing issue reference ([eefa884](eefa884)) * architecture diagram ([5f4970f](5f4970f)), closes [#7](#7) * cover projecting 1-to-1 relations ([#32](#32)) ([bb70ea4](bb70ea4)) * **jsdoc:** docPropagation docs ([#55](#55)) ([5b4e5e6](5b4e5e6)) * list enum members in jsdoc ([#92](#92)) ([d806d56](d806d56)) * mention patch ver support policy ([8e61651](8e61651)) * peer deps validation ([4992741](4992741)), closes [#2](#2) * **readme:** adjust readiness disclaimer ([0e94cea](0e94cea)) * **readme:** remove now-resolved limitation caveat ([b5fed98](b5fed98)) * setup hello world nextra site ([784705c](784705c)) * update to nextra 2.0.0 ([#232](#232)) ([fccffd5](fccffd5)) * update to nexus@^1.1 api ([#95](#95)) ([1d31a76](1d31a76)) * **website:** fix links in docs ([#144](#144)) ([abd56f2](abd56f2)) ### Testing * **e2e:** adjust kitchen-sink snapshot ([#234](#234)) ([f831369](f831369)) * **e2e:** adjust ts-node-import-error snapshot ([#230](#230)) ([e464f2f](e464f2f)) * extract hardcoded package.json declarations to fixtures ([#309](#309)) ([8cebf8a](8cebf8a)) ### chore * **deps:** update dependency graphql to v16 ([#256](#256)) ([b6678a4](b6678a4)) ### Bug fixes * add lodash as production dep ([627aa54](627aa54)), closes [#107](#107) * bring back support for jest ([1705a54](1705a54)), closes [#137](#137) * **deps:** update dependency @reach/skip-nav to v0.18.0 ([#300](#300)) ([1ece744](1ece744)) * **deps:** update dependency @types/node to v18.11.17 ([#324](#324)) ([86a6c4d](86a6c4d)) * **deps:** update dependency debug to ^4.3.4 ([#289](#289)) ([53a5b47](53a5b47)) * **deps:** update dependency decimal.js to ^10.4.2 ([#301](#301)) ([38d02f6](38d02f6)) * **deps:** update dependency decimal.js to ^10.4.3 ([#325](#325)) ([21cea98](21cea98)) * **deps:** update dependency dotenv to ^9.0.2 ([#326](#326)) ([fca26b0](fca26b0)) * **deps:** update dependency fs-jetpack to v5 ([#255](#255)) ([7fdb71c](7fdb71c)) * **deps:** update dependency graphql-scalars to ^1.20.1 ([#302](#302)) ([38d47d6](38d47d6)) * **deps:** update dependency kleur to ^4.1.5 ([#290](#290)) ([3c2310f](3c2310f)) * **deps:** update dependency nextra to v2.0.0-beta.41 ([#273](#273)) ([a523891](a523891)) * **deps:** update dependency nextra-theme-docs to v2.0.0-beta.41 ([#274](#274)) ([73f99bf](73f99bf)) * **deps:** update dependency semver to ^7.3.8 ([#291](#291)) ([1cbfb25](1cbfb25)) * **deps:** update dependency tslib to ^2.4.1 ([#303](#303)) ([ec603b0](ec603b0)) * **deps:** update dependency typescript to v4.9.4 ([#251](#251)) ([bb3d9d7](bb3d9d7)) * **deps:** update nextra packages to v2.0.1 ([#316](#316)) ([f3923e2](f3923e2)) * **deps:** update nextra packages to v2.0.2 ([#346](#346)) ([ee97081](ee97081)) * **deps:** update nextra packages to v2.0.3 ([#349](#349)) ([84170d1](84170d1)) * description type should not be null ([#24](#24)) ([cffc94d](cffc94d)) * **docs:** update custom settings example ([#215](#215)) ([8b56ec9](8b56ec9)) * endent via dedent introduces unexpected newlines on Windows ([#51](#51)) ([2447f56](2447f56)) * graphql peerDependency ([#233](#233)) ([0086763](0086763)) * grpahql and floggy dependencies ([#188](#188)) ([774624f](774624f)) * handle multiline prisma docs ([#134](#134)) ([f9e2f2e](f9e2f2e)) * import path on windows ([#145](#145)) ([4699b90](4699b90)) * import prisma client for instanceof check using configured path ([#62](#62)) ([b796689](b796689)) * list def typing ([#77](#77)) ([72cc944](72cc944)) * module `fs-jetpack` not found ([#11](#11)) ([4f83b26](4f83b26)) * ncc support ([#113](#113)) ([9c7e552](9c7e552)) * output mjs files for ES modules support ([#192](#192)) ([cf59aae](cf59aae)) * remove bad prisma client on ctx check & export $settings ([#60](#60)) ([60a77cd](60a77cd)) * remove colors from the the result to fix the local test ([#225](#225)) ([684fa20](684fa20)) * remove lingering console.log ([d16f763](d16f763)) * resolve path ~ when checking if can import at @prisma/client ([#104](#104)) ([8eee072](8eee072)) * scalars module only exports named exports ([#187](#187)) ([5223f9e](5223f9e)) * setup nodejs 14 for publishing job on ci ([4cbb0de](4cbb0de)) * typegen guards for undefined relations ([#126](#126)) ([a27fc1a](a27fc1a)) * update prisma client dep to 3 ([#148](#148)) ([fa58349](fa58349)) * use import id @prisma/client by default when possible ([#88](#88)) ([5599a65](5599a65)) ### CI * add pull request workflow documentation build commit status check ([#314](#314)) ([4522e1d](4522e1d)) * configure renovate config to update only the lock file for prisma packages ([#344](#344)) ([3560a41](3560a41)) * configure renovate to automerge minor and patch chore(deps) ([#284](#284)) ([2022809](2022809)) * extract tests into reusable workflow and refactor releases ([#345](#345)) ([27e99a8](27e99a8)) * fix package version ([#317](#317)) ([4e02312](4e02312)) * group nextra packages for renovate upgrades ([#315](#315)) ([21471e8](21471e8)) * ignore execa from renovate updates due exclusive esm support ([#337](#337)) ([99110c8](99110c8)) * refactor tests to use local database ([#311](#311)) ([7559995](7559995)) * reflect local database for tests in trunk github actions workflow ([#312](#312)) ([8bfd561](8bfd561)) * switch dependencies into dev dependencies in tests ([#319](#319)) ([11ee750](11ee750)) * unify trunk and pull request github actions workflow ([#313](#313)) ([6a73b25](6a73b25)) * update renovate config to use version range to ignore packages migrated to pure esm ([#343](#343)) ([23ed616](23ed616))

rostislav-simonik-nexus-prisma-admin · 2023-01-07T08:24:39Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

iddan changed the title ~~Add support for big int scalar~~ Add support for BigInt scalar May 22, 2021

jasonkuhrt suggested changes May 25, 2021

View reviewed changes

tests/e2e/__snapshots__/e2e.test.ts.snap Show resolved Hide resolved

src/entrypoints/scalars.ts Outdated Show resolved Hide resolved

src/generator/models/declaration.ts Show resolved Hide resolved

README.md Show resolved Hide resolved

src/scalars/BigInt.ts Show resolved Hide resolved

iddan force-pushed the feature/bigint branch from 9d2a129 to e9013d7 Compare June 22, 2021 18:40

iddan added 3 commits June 23, 2021 00:20

Add support for big int scalar

3f990d6

Add documentation about bigint to readme

861ce93

Add documentation regarding node.js version

c661dc9

iddan force-pushed the feature/bigint branch from fdff934 to c661dc9 Compare June 22, 2021 21:22

iddan added 6 commits June 23, 2021 00:29

Update snapshots

8cf64dc

Manually fix snapshots

5489424

Fix docs regarding bytes

a023f7b

Add additional info column to types table

398b5df

Correct name of StandardGraphQLScalarTypes

ef96eb1

Add link to MDN in BigInt type

df9034e

jasonkuhrt changed the title ~~Add support for BigInt scalar~~ feat: add support for BigInt scalar Jun 23, 2021

jasonkuhrt reviewed Jun 23, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

jasonkuhrt reviewed Jun 23, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

Apply suggestions from code review

e6d06b8

jasonkuhrt reviewed Jun 23, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

Update README.md

fe14463

jasonkuhrt reviewed Jun 23, 2021

View reviewed changes

tests/e2e/e2e.test.ts Show resolved Hide resolved

Add GraphQL result type assertion in e2e

5655dc0

iddan added 2 commits June 24, 2021 01:13

Fix snaphots

86d641a

Fix e2e test

d3118d7

jasonkuhrt mentioned this pull request Jun 24, 2021

Allow custom serializer/deserializer for custom scalars remorses/genql#57

Open

jasonkuhrt and others added 8 commits June 23, 2021 22:57

Merge branch 'main' into feature/bigint

feee915

Merge branch 'main' of https://github.com/prisma/nexus-prisma into fe…

028b735

…ature/bigint

Update snapshots

a92b027

Fix peerDepValidator snap

c0629cf

Update snapshots

4597ede

Correct type assertions in e2e test

e460536

Use parseValue assertion for bigint in e2e test

78f023c

Update readme

b125613

jasonkuhrt approved these changes Jul 7, 2021

View reviewed changes

jasonkuhrt merged commit 67ce824 into graphql-nexus:main Jul 7, 2021

iddan deleted the feature/bigint branch July 7, 2021 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for BigInt scalar #56

feat: add support for BigInt scalar #56

iddan commented May 22, 2021 •

edited by jasonkuhrt

Loading

codecov-commenter commented May 22, 2021 •

edited

Loading

jasonkuhrt commented May 25, 2021

jasonkuhrt commented Jun 1, 2021

iddan commented Jun 2, 2021

iddan commented Jun 3, 2021

jasonkuhrt commented Jun 21, 2021

jasonkuhrt commented Jun 22, 2021 •

edited

Loading

jasonkuhrt commented Jun 22, 2021

jasonkuhrt commented Jun 23, 2021

jasonkuhrt left a comment

rostislav-simonik-nexus-prisma-admin commented Jan 7, 2023

feat: add support for BigInt scalar #56

feat: add support for BigInt scalar #56

Conversation

iddan commented May 22, 2021 • edited by jasonkuhrt Loading

TODO

codecov-commenter commented May 22, 2021 • edited Loading

Codecov Report

jasonkuhrt commented May 25, 2021

jasonkuhrt commented Jun 1, 2021

iddan commented Jun 2, 2021

iddan commented Jun 3, 2021

jasonkuhrt commented Jun 21, 2021

jasonkuhrt commented Jun 22, 2021 • edited Loading

jasonkuhrt commented Jun 22, 2021

jasonkuhrt commented Jun 23, 2021

jasonkuhrt left a comment

Choose a reason for hiding this comment

rostislav-simonik-nexus-prisma-admin commented Jan 7, 2023

iddan commented May 22, 2021 •

edited by jasonkuhrt

Loading

codecov-commenter commented May 22, 2021 •

edited

Loading

jasonkuhrt commented Jun 22, 2021 •

edited

Loading