-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup website for docs #97
Conversation
2fbbfb2
to
cebe026
Compare
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 50.81% 50.81%
=======================================
Files 34 34
Lines 555 555
Branches 102 102
=======================================
Hits 282 282
Misses 257 257
Partials 16 16 |
Co-authored-by: Koniuszy <44303865+koniuszy@users.noreply.github.com>
@iddan I'm ready to look at this this week. Can you share a TL;DR about the change and how this works? You can answer in the form of additions to |
The change adds the docs directory. Within it there is a Nextra website initialised with the README text as a markdown page and configured with support for GFM markdown support |
@iddan did you figure out hosting yet? gh-pages? We could also consider Vercel I guess if need be. |
Since it’s Next app without SSR we can export the website to static files and host them in GitHub pages |
This guide defines how to do it correctly: https://lukaszwozniak.dev/blog/deploy-nextjs-app-to-github-pages-using-github-actions/ |
@iddan can you please setup deployment automation. Here's my suggestion:
Regarding (2) the issue I see with that is that it doesn't not support preview deployments. With Vercel we get preview deployments. If we cannot have preview deployments with gh-pages then I suggest Vercel... I think. |
I would also like an npm script in the repo to manually force-deploy the website too. |
I don’t think you can get preview deploys with GitHub Pages, only services like Vercel and Netlify offer this feature |
@iddan let's use Vercel then. I can use the Prisma Vercel account for this. I will set that up soon. |
Done, but in order to proceed I need to merge some kind of docs thing to complete configuration. Right now because this isn't on trunk Verecl will not let me specify I will try to setup a minimal nextra thing on trunk now. |
@iddan please rebase You should start getting preview deployments now... Production: https://nexus-prisma.vercel.app/ |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/prisma-adp/nexus-prisma/2WN2QE1cq8SYrvsKJnyVme3kW8MW |
Ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things:
- The contents are out of date with the current README on trunk
- The trunk README should become minimal and link to the website
Looking at this:
If any of the following is a quickwin please do:
- Can we have more level of nesting in the left sidebar?
- Can we remove the "Index" parent section, makes no sense
- I guess if we combine the two points above it means each current subsection becomes a top level section and then some new subsections would bubble up
- styling isn't very nice but not sure there is an easy theme we can plug there
- don't like the code highlighting theme
- Copywrite should be Prisma Data Inc.
- Would like to remove the "edit this page" link
I setup a new domain for us https://nexus.prisma.io/ Thanks @janpio for the slick name idea. |
The text I’ve put there was for demonstration purposes. I was expecting once this PR is merged that the content of the website will be changed as you’d like. I’ll make the changes. |
Can the PR be merged and improvements to the left points be done in additional PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iddan!
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #33