Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MaybePromiseDeep for arrays #474

Closed
wants to merge 1 commit into from
Closed

Fix MaybePromiseDeep for arrays #474

wants to merge 1 commit into from

Conversation

Sytten
Copy link
Collaborator

@Sytten Sytten commented Aug 2, 2020

Goal

  • Allow MaybePromiseDeep to work with promises with a then returning an array but where the definition allows for null

Documentation

Use this playground to see the problem. If you remove lines 19-22 it will show an error.

References

Fixes #470

jasonkuhrt added a commit that referenced this pull request Aug 3, 2020
jasonkuhrt pushed a commit that referenced this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promise like should not force null if the parent promise is not nullable
1 participant