Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input fields with default should not be typed as optional #563

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

Weakky
Copy link
Member

@Weakky Weakky commented Oct 19, 2020

Closes #127

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #563 into develop will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #563      +/-   ##
===========================================
+ Coverage    93.99%   94.03%   +0.04%     
===========================================
  Files           42       42              
  Lines         2414     2414              
  Branches       500      500              
===========================================
+ Hits          2269     2270       +1     
+ Misses         145      144       -1     

Copy link
Contributor

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Weakky Weakky merged commit 10208e3 into develop Oct 19, 2020
@Weakky Weakky deleted the fix/input-field-default branch October 19, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Arg Value Type Error
2 participants