feat: Add custom name options to Relay Connection plugin #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the original commit was based on a stale |
Codecov Report
@@ Coverage Diff @@
## main #744 +/- ##
==========================================
+ Coverage 93.77% 93.78% +0.01%
==========================================
Files 46 46
Lines 2922 2930 +8
Branches 688 692 +4
==========================================
+ Hits 2740 2748 +8
Misses 180 180
Partials 2 2 |
|
Hey @tgriesser. Happy new year! Have you had a chance to take a look at this PR? Anything you want to add or change? |
|
Nope, seems good! Mind rebasing it one more time? I'll look to get this merged in right away |
Adds a getConnectionName and getEdgeName option to both the global plugin config as well as the field config for the Relay Connection plugin. This gives the user the ability to control the names of the generated connection and edge types in the schema. Closes #697
|
Done! |
tgriesser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a getConnectionName and getEdgeName option to both the global
plugin config as well as the field config for the Relay Connection
plugin. This gives the user the ability to control the names of the
generated connection and edge types in the schema.
Closes #697
Prettier seems to have re-formatted some comments. I can remove these changes or put them in a separate commit if needed. Also, please let me know if the option descriptions and the tests are acceptable.
cc: @tgriesser