Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Correct an object's value in the tutorial #808

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

niyabits
Copy link
Contributor

In the ContextType Object, the value of export should be Context instead of ContextModule (see Line 133)
On line 62, the name of the exported interface is Context.

I have noticed that autocompletion of Prisma doesn't work because of the misspelling :)

When I checked the repository of the tutorial the value of export was correct.
https://github.com/graphql-nexus/tutorial/blob/e7a1988eded47a818398d14d823e45423ddeb3dd/api/schema.ts#L12

In the ContextType Object, the value of `export` should be `Context` instead of `ContextModule` (see Line 133)
On line 62, the name of the exported interface is `Context`.

I have noticed that autocompletion of Prisma doesn't work because of the misspelling :)

When I checked the repository of the tutorial the value of `export` was correct.
https://github.com/graphql-nexus/tutorial/blob/e7a1988eded47a818398d14d823e45423ddeb3dd/api/schema.ts#L12
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #808 (f394ff1) into main (0ce49b9) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   93.91%   93.84%   -0.07%     
==========================================
  Files          46       46              
  Lines        2959     2926      -33     
  Branches      697      693       -4     
==========================================
- Hits         2779     2746      -33     
  Misses        178      178              
  Partials        2        2              

Copy link
Contributor

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@jasonkuhrt jasonkuhrt changed the title Docs: Correct an object's value in the tutorial chore(docs): Correct an object's value in the tutorial Feb 3, 2021
@jasonkuhrt jasonkuhrt merged commit 0b28c77 into graphql-nexus:main Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants