Skip to content

queryset.count() optimized #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

queryset.count() optimized #1227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion graphene_django/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from functools import partial

from django.db.models.query import QuerySet
from django.db.models import Count
from graphql_relay.connection.arrayconnection import (
connection_from_array_slice,
cursor_to_offset,
Expand Down Expand Up @@ -144,7 +145,7 @@ def resolve_connection(cls, connection, args, iterable, max_limit=None):
iterable = maybe_queryset(iterable)

if isinstance(iterable, QuerySet):
list_length = iterable.count()
list_length = iterable.aggregate(Count('pk'))['pk__count']
else:
list_length = len(iterable)
list_slice_length = (
Expand Down