-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for model types to be placed on input fields [WIP] feedback wanted #160
Conversation
add a new subclass and a few tests [WIP]
Thanks for this -- tried and it and I get errors when the reducer runs
But it also might be an instance of this error: #139 or related to the fact the graphene reducer doesn't recognize the type DjanngoModelInput when running is_graphene_type() . |
bdc7189
to
f93251b
Compare
Thanks for the idea. An easy way to generate I'll point out a few similar alternatives.
Both of those options allow for validation and such to be handled by the serializer/form. They also have a default Are there any advantages of this approach over those two solutions that I am not thinking of? |
@colanconnon still interested to work on this? |
I'd like to tidy up some of the PRs, so if we still want to work on this let me know or I will close this in 1 week. |
Add the ability to have a model type on the input class in mutations for more code reuse. This is my first time contributing so some feedback is welcome! I am borrowing some ideas from #121