Apply camel case converter to field names in DRF errors

[kalekseev]

This change eliminates inconsistency between schema field names and serializer errors field names

[coveralls]

Coverage increased (+0.005%) to 94.523% when pulling adb0947 on kalekseev:camel-case-drf-errors into f76f38e on graphql-python:master.

[kalekseev]

Though TypeError has type string[], I think nested serializers should be supported too? like if errors = {entity: { option_a: ["This Field is required"] }} the option_a should be converted to optionA, what do you think?

[patrick91]

I quite like this, even thought I think I'll rewrite the implementation of the errors for the serializer mutation, but I'll probably keep the current implementation for backwards compatibility.

@syrusakbary what do think of this pull request? It breaks the compatibility with user using errors and having fields with _ in them, but it is definitely nicer than before I guess

[artofhuman]

Should form errors convert to camel case too? https://github.com/graphql-python/graphene-django/blob/master/graphene_django/forms/mutation.py#L49

[kalekseev]

Should form errors convert to camel case too? https://github.com/graphql-python/graphene-django/blob/master/graphene_django/forms/mutation.py#L49

I can implement that in this pr but both are breaking changes so need decision from author first.

[artofhuman]

Maybe for easy release we need another option in the schema. Like:

schema = Schema(Query, auto_camelcase=True, errors_camelcase=True)

Or if it related only for this packed use some global config like DJANGO_GRAPHENE_CAMELCASE_ERRORS=True

And check this options here with deprecation message. In major release check only auto_camelcase

And what if auto_camelcase=False, i think we should not use camelcase for errors. WDYT?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jkimbo]

This looks like it's still a useful change so don't close this stalebot!

@kalekseev so that we can get this merged without it being a breaking change could you add a flag like DJANGO_GRAPHENE_CAMELCASE_ERRORS=True that @artofhuman suggested?

[kalekseev]

Hi guys, updated pr with recursive conversion to camel case for nested serializers support, added flag to enable this change.

[artofhuman]

👍

[zbyte64]

Love the ErrorType.from_errors method.

[jkimbo]

This looks great thanks @kalekseev !