Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for write_only fields in SerializerMutation #555

Conversation

kamilkijak
Copy link

Closes: #487

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.537% when pulling d72b279 on kamilkijak:feature/add-support-for-drf-write-only-fields into f76f38e on graphql-python:master.

@kamilkijak
Copy link
Author

@syrusakbary @patrick91 I would appreciate your feedback guys 🙂

@danpalmer danpalmer removed their request for review March 20, 2019 20:20
@danpalmer
Copy link
Collaborator

I'm afraid I don't have any experience with Django Rest Framework, so I'm going to opt-out of reviewing this one.

@jkimbo
Copy link
Member

jkimbo commented Mar 31, 2019

Don't have any experience with Django Rest Framework either

@jkimbo jkimbo requested review from zbyte64 and removed request for jkimbo March 31, 2019 11:29
@firaskafri
Copy link
Collaborator

Nice! Approved from my side.

@firaskafri firaskafri requested a review from jkimbo April 2, 2019 19:39
@jkimbo jkimbo merged commit c90c27f into graphql-python:master Jun 9, 2019
@jkimbo
Copy link
Member

jkimbo commented Jun 9, 2019

Merged. Thanks @kamilkijak

@Shehab-Muhammad
Copy link

Could you release this update to the latest version on pip?

@jkimbo jkimbo mentioned this pull request Jul 9, 2019
@codetalks-new
Copy link

Hi, I feel we also need to exclude the read_only field in the InputType.

        if is_not_in_only or is_excluded:
            continue
        if is_input and field.read_only:
            continue

@jkimbo
Copy link
Member

jkimbo commented Jul 13, 2019

@Shehab-Muhammad the latest version has been released as v2.4.0

@banxi1988 please make a PR if there are still features that need implementing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SerializerMutation don't excluded write_only fields
9 participants