Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: BaseDjangoFormMutation should use from_global_id when fetching e… #568

Closed
wants to merge 1 commit into from

Conversation

r3stm4n
Copy link

@r3stm4n r3stm4n commented Jan 5, 2019

…xisting instance #460

Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we might want to assert the first component returned from_global_id matches the model name.

firaskafri
firaskafri previously approved these changes Mar 20, 2019
@firaskafri
Copy link
Collaborator

@zbyte64 the tests unexpectedly seem to be failing though

@zbyte64 zbyte64 self-requested a review March 20, 2019 20:06
@zbyte64
Copy link
Collaborator

zbyte64 commented Mar 20, 2019

You're right...

I see that #546 attempts to do the same thing but includes updated tests,

@stale
Copy link

stale bot commented Jun 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 11, 2019
@stale stale bot closed this Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants