Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Graphene 3 (continuation) #812

Closed
wants to merge 21 commits into from
Closed

WIP: Graphene 3 (continuation) #812

wants to merge 21 commits into from

Conversation

rhizoome
Copy link
Contributor

@rhizoome rhizoome commented Nov 20, 2019

@rhizoome
Copy link
Contributor Author

Rebasing was a mistake, it introduces to much uncertainty.

@BfutureP BfutureP mentioned this pull request Dec 11, 2019
@jkimbo
Copy link
Member

jkimbo commented Dec 26, 2019

This looks really good @ganwell . Is the outstanding issue on Graphene the only thing blocking this?

@ulgens
Copy link
Collaborator

ulgens commented Feb 5, 2020

Any progress on this?

@rhizoome
Copy link
Contributor Author

rhizoome commented Feb 5, 2020

@jkimbo Last month I started to run graphen-django v3 against our test-suite (https://github.com/projectcaluma/caluma), but I got distracted by other projects. I was able to reduce errors from 500 of 600 to about 150 of 600. I assume there are still bugs in the graphql*/graphene* projects, some are in caluma itself of course. I hope I can resume the work in February.

@jkimbo
Copy link
Member

jkimbo commented Feb 8, 2020

@ganwell thanks for the update. FYI I've merged graphql-python/graphene#1111 so you should be unblocked there.

@ulgens ulgens mentioned this pull request Mar 15, 2020
@rhizoome
Copy link
Contributor Author

rhizoome commented Apr 1, 2020

I will try to switch to #905 and continue my integration test

@rhizoome
Copy link
Contributor Author

Closing because of v3 branch

@rhizoome rhizoome closed this Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants