-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Graphene 3 (continuation) #812
Conversation
Fields starting with __ are reserved for introspection
graphql-core 3 prints the descriptions, and skips `schema` if it's the default one (query: Query)
Connection resolvers have access to pagination arguments.
Some of the tests show the problem described here: graphql-python/graphql-core#61
It was only needed for Python 2.7
Rebasing was a mistake, it introduces to much uncertainty. |
This looks really good @ganwell . Is the outstanding issue on Graphene the only thing blocking this? |
Any progress on this? |
@jkimbo Last month I started to run graphen-django v3 against our test-suite (https://github.com/projectcaluma/caluma), but I got distracted by other projects. I was able to reduce errors from 500 of 600 to about 150 of 600. I assume there are still bugs in the graphql*/graphene* projects, some are in caluma itself of course. I hope I can resume the work in February. |
@ganwell thanks for the update. FYI I've merged graphql-python/graphene#1111 so you should be unblocked there. |
I will try to switch to #905 and continue my integration test |
Closing because of v3 branch |
Continuation of #774
Adding fixes needed to run Tracking issue for graphql 3.0 projectcaluma/caluma#814 unittests
Still very much WIP
Related Issues:
My workspace: https://github.com/ganwell/gwork