Skip to content

Conversation

@mak626
Copy link
Contributor

@mak626 mak626 commented Oct 9, 2025

@mak626 mak626 marked this pull request as ready for review October 9, 2025 07:24
@arunsureshkumar arunsureshkumar merged commit 4ab024e into graphql-python:main Oct 9, 2025
9 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18368728776

Details

  • 130 of 164 (79.27%) changed or added relevant lines in 27 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 74.51%

Changes Missing Coverage Covered Lines Changed/Added Lines %
graphene_federation/directives/from_context.py 15 18 83.33%
graphene_federation/apollo_versions/init.py 11 15 73.33%
graphene_federation/directives/context.py 5 14 35.71%
graphene_federation/directives/cost.py 5 14 35.71%
graphene_federation/directives/list_size.py 5 14 35.71%
Files with Coverage Reduction New Missed Lines %
graphene_federation/apollo_versions/init.py 2 74.0%
Totals Coverage Status
Change from base Build 9516778908: 0.9%
Covered Lines: 760
Relevant Lines: 1020

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom directives break when combined with Graphene arguments

3 participants