-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from travis to github actions #316
Conversation
@jetzhou This PR fixes the deploy script to unblock v3 migration |
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
=========================================
Coverage ? 97.65%
=========================================
Files ? 9
Lines ? 596
Branches ? 0
=========================================
Hits ? 582
Misses ? 14
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The code coverage doesn't seem to be working though.
2.7: py27 | ||
3.5: py35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These can probably be removed since they're not being tested against.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will follow up with coverage fix and removing these tests
Can we get this merged? 🙏🏼 I'd like to run the tests on PR #317 (currently they're passing locally). This is important to get graphene to v3 |
graphql-python/graphene#1127
Use github action for linting, deploying and testing. Removes travis.
Fixes automated deploys.