Skip to content

doc:connection:precise expected return of connection resolver #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

doc:connection:precise expected return of connection resolver #892

wants to merge 1 commit into from

Conversation

antoine-gallix
Copy link

@antoine-gallix antoine-gallix commented Jan 17, 2019

connection documentation lacks a lot of details: #887

Copy link
Contributor

@ekampf ekampf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @antoine-gallix,
I have a problem with the statement "The resolver of a connection field should return a list" as its usually not True.
graphene has the capability to automatically turn a list into a Connection structure but that's not the common use case.
In fact, I can't really think of a real production use-case for this - loading an entire dataset into memory and only returning a portion of it via Connection.

The common use case for a Connection. is where the resolver return the entire Connection structure...

@antoine-gallix
Copy link
Author

I wanted to improve the documentation because it was not clear to me what a resolver function was supposed to return. We managed to make it work by returning a list of objects, as no other way is documented. But as you seems to know better what the standard practice is, could you please explain it in detail so we can improve the documentation together?

@phalt
Copy link

phalt commented May 7, 2019

@ekampf can you suggest a better doc for this?

@stale
Copy link

stale bot commented Jul 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 29, 2019
@stale stale bot closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants