Update aniso8601 dependency to allow versions 4+. #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just update to |
|
To not break people on aniso8601 3.x-5.x |
|
@crunk1 it feels wrong. Saying any version |
|
Updated. I don't know what your thoughts are on allowing future compatibility changes, but take a look. |
ekampf
approved these changes
May 2, 2019
phalt
approved these changes
May 7, 2019
mvanlonden
approved these changes
May 7, 2019
|
Hi there.I received the same warning as @crunk1 and I found this PR. |
|
Pyup is nice too: https://pyup.io/ |
AdrianLC
added a commit
to AdrianLC/graphene
that referenced
this pull request
Jun 5, 2019
This was changed on graphql-python#935 to fix a warning when installing newer versions but we are now getting an error that 6.0.0 doesn't match 6.0.*: ``` ERROR: graphene 2.1.5 has requirement aniso8601<=6.0.*,>=3, but you'll have aniso8601 6.0.0 which is incompatible. ``` I don't think that the `*` are recognized as the same version than.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally updated my local aniso8601 to 6.0.0. My projects were running fine with graphene==2.1.3 and aniso8601==6.0.0. Later, I noticed the pip warnings telling me they were incompatible versions.
I ran tox against aniso8601 versions 4.0.0, 5.0.0, and 6.0.0 and compared against the results from running against 3.0.2. Results look the same at a glance.