-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement nullvalue #119
base: master
Are you sure you want to change the base?
Implement nullvalue #119
Conversation
I will happily merge this if we can add more tests like in the ref implementation! |
@yen223 Do you plan to continu this PR? That's a very useful feature. |
- addresses graphql-python#118 - initial implementation by @yen223 in PR graphql-python#119
- addresses graphql-python#118 - initial implementation by @yen223 in PR graphql-python#119
b1f26c1
to
a7ce75e
Compare
What's the status of this pull request? This would be very helpful for us. |
This feature would be very useful. Right now, I have to create another mutation that's used only for setting argument object fields to null. |
- addresses graphql-python#118 - initial implementation by @yen223 in PR graphql-python#119
- addresses graphql-python#118 - initial implementation by @yen223 in PR graphql-python#119
- addresses graphql-python#118 - initial implementation by @yen223 in PR graphql-python#119
@syrusakbary which, specifically, of the tests there would you like implemented? It seems to me that project has a broader set of tests overall than this one and the tests @yen223 added are consistent with the scope of the existing tests. |
Any update on this? thanks |
Joining the crowd of onlookers waiting for updates on this PR. Thanks @syrusakbary |
likewise, would very much like this to be possible |
Joining the crowd of onlookers waiting for updates on this PR. Thanks @syrusakbary |
Maybe the https://github.com/graphql-python/graphql-core/issues/249 release might resolve this issue, @jkimbo? |
@brabeji yes the graphql-core v3 (#249) will resolve this issue. Graphql-core v3 is going to be graphql-core-next which is a complete rewrite bringing it up to feature parity with graphql.js |
- addresses graphql-python#118 - initial implementation by @yen223 in PR graphql-python#119
Resolves #118