Skip to content

Use identity instead of hash for caching subfields in collect_subfields #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2019
Merged

Use identity instead of hash for caching subfields in collect_subfields #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/graphql/execution/execute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def __init__(
self.middleware_manager = middleware_manager
self.errors = errors
self._subfields_cache: Dict[
Tuple[GraphQLObjectType, Tuple[FieldNode, ...]], Dict[str, List[FieldNode]]
Tuple[GraphQLObjectType, int], Dict[str, List[FieldNode]]
] = {}

@classmethod
Expand Down Expand Up @@ -998,7 +998,7 @@ def collect_subfields(
subfields are not repeatedly calculated, which saves overhead when resolving
lists of values.
"""
cache_key = return_type, tuple(field_nodes)
cache_key = return_type, id(field_nodes)
sub_field_nodes = self._subfields_cache.get(cache_key)
if sub_field_nodes is None:
sub_field_nodes = {}
Expand Down