Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v3.0.0b7 #122

Merged
merged 1 commit into from
Oct 16, 2023
Merged

release: v3.0.0b7 #122

merged 1 commit into from
Oct 16, 2023

Conversation

kiendang
Copy link
Collaborator

No description provided.

@erikwrede
Copy link
Member

erikwrede commented Oct 15, 2023

@kiendang Any reason not to go straight to RC1 this time? Afaik we're up to date on the frameworks now, and we can always deliver async/WS support in later releases.

@kiendang
Copy link
Collaborator Author

No particular reason. Yup I think we're good for RC1.

@kiendang
Copy link
Collaborator Author

kiendang commented Oct 15, 2023

Ah actually aiohttp just released their first 3.9 beta version (3.9.0b0) to support python 3.12. See aio-libs/aiohttp#7675.
Plus looks like there's a failed test in test_version.py (https://github.com/graphql-python/graphql-server/actions/runs/6525071080/job/17717371331?pr=122) when I tried to change version to 3.0.0rc1. How about we do a 3.0.0b7 now then do RC1 later when aiohttp 3.9.0 stable is out plus adding tests for Python 3.12? I'll fix the tests too.

@erikwrede
Copy link
Member

erikwrede commented Oct 15, 2023

@kiendang sounds good! Test is probably breaking because we haven't done any RCs here yet. If we push the beta I'm all open for going straight to major release after that. No major graphql-server functionality should change anymore by waiting for 3.12.

@kiendang kiendang merged commit 8af13c0 into master Oct 16, 2023
16 checks passed
@kiendang kiendang deleted the release-v3.0.0b7 branch October 16, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants